[slabbi]

Ok, I see.

[slabbi]

Great, it would be very nice if you could check this. I’d like to modify “catcheverest_footer_content()”.

In Germany you have to add an “Impressum” (a legal notice that comprises at least your name, address, contact information, and other legal information dependent on the site content and is also required for private, non commercial sites) by law that is reachable from the front page. Lots of sites use the footer to provide the required link and so do I.

Other users might add an old fashioned counter or other additional information.

[slabbi]

@Sakin: Yes, I like to move my changes to a child theme and actually most of my patches have already been moved but not all because some functions do not check if they already exist.

I do not understand your comment “in all the codes that we allowed to change in child theme”. You already allow to change everything (because of the GPL) but you do not allow to change everything using a child theme which is the recommended way.

[slabbi]

*wondering*

The free themes are released under GPL, so you allow to change the main theme basically.

Adding “functions_exists()” does only mean to create child themes more convenient while leaving the main theme unchanged.

So as far as I understand your statement: hacking the main theme is ok, creating a fork is also ok, but leaving it unchanged (and creating an independent child theme so hacks must not be applied again and again) is not wanted?

[slabbi]

Great, thanks for the fast answer, Sakin.
Works fine, exactly what I have been looking for. 🙂

[slabbi]

I have already reported a fix for this:

In catcheverest-functions.php in line 70 (approx.) add
catcheverest_pass_slider_value();
below
wp_enqueue_script( ‘catcheverest-slider’, get_template_directory_uri() . ‘/js/catcheverest-slider.js’, array( ‘jquery-cycle’ ), ‘20130114’, true );

So it should read
$enableslider = $options[ ‘enable_slider’ ];
if ( ( $enableslider == ‘enable-slider-allpage’ ) || ( ( is_front_page() || ( is_home() && $page_for_posts != $page_id ) ) && $enableslider == ‘enable-slider-homepage’ ) ) {
wp_enqueue_script( ‘catcheverest-slider’, get_template_directory_uri() . ‘/js/catcheverest-slider.js’, array( ‘jquery-cycle’ ), ‘20130114’, true );
catcheverest_pass_slider_value(); /* SSL */
}

The problem is that wp_localize_script() is executed before wp_enqueue_script is executed on some systems (also on my). So it fails and a required Javascript variable is not created.

[Author]

Posts