[greg2015]

Well, as per my first post, I’ve removed the password protect for now.
I cannot have the live site with the issue.

There is nothing to see really, if I make the /wp-admin directory unavailable to public (password protected) the header image is simply not there.

Something in your theme seems to need public access to the /wp-admin directory to link to the header, which is odd as the header image is in /wp-content nothing to do with /wp-admin:

src="http://www.1stchoicetilingandplastering.co.uk/wp-content/uploads/2015/01/first-choice-tiling-plastering-logo.png"

[greg2015]

Sure, thanks for looking.
http://www.1stchoicetilingandplastering.co.uk/

I’m happy to do the work to fix it, just need a pointer in the right direction as to why public access to /wp-admin is required for your theme to display the header image.

Thanks

[greg2015]

I’ll ask another way, my explanation perhaps confused what the actual underlying issue is here.

If I block public access to the /wp-admin/ folder (regardless of method), why would your Catch Everest theme not show the header image, but shows everything else?

I do not know why, as everything else works.
The header logo is added via the theme’s own settings, and the header image is in the standard media library along with other images, of which all other images show up perfectly fine.

Thanks.

[greg2015]

I ended up editing the plugin code. I know this is not ideal, but have it monitored and if the plugin is updated I can just re-edit it. (sigh)

The plugin core code has HTML/CSS in it, which is stupid. I wish these popular plugins would separate business logic from display/view more so they’re more controllable.

Thanks again Sakin!

[greg2015]

Hi,

Thanks for the reply, and for looking into it further. I appreciate you likely have spare little time, so thanks.

I still think the widget is not to blame, as the shortcode is only called in sidebar widget, so not called until all page divs (etc) are closed.
Thanks anyway. I’ll keep digging, something somewhere is calling the DIV where it shouldn’t.

Cheers

[greg2015]

I’ve done some more thinking/investigating (I could be on the wrong track, but..)

Looking through your theme’s code files, the only place I can see that your theme could possibly cause this issue (ie load a sidebar DIV before it loads the sidebar) is in page.php.
Specifically this line:
<?php get_template_part( 'content', 'page' ); ?>

I say that because after that line all the page.php does is close the loop, close the main page content divs, THEN call the sidebar.
The issue cannot be in the get_sidebar() as that is called after the main page content divs are closed, and the “rogue DIV” is before that.

Is there anything you do with that function in your theme which could cause this?
Or is this perhaps something to do with the way WordPress uses that function?

I’m happy to do the grunt work and check files and debug myself, if you can give me an idea and point in the right direction.
I’ve been through all your relevant functions and files and cannot see anything else that would call a sidebar widget div in the main page area.

Thanks again

[greg2015]

Hi Sakin,

Thanks for the reply. I meant no insult to your software, it’s very good, especially considering it’s much more than just a theme!

I checked the about-us page and there is no shortcode at all. The plugin is not required to be called in the page, it’s needed in the sidebar.

I also tried making a new test page, and the test page had no text in it whatsoever, just a title, and set to use “right sidebar” through your theme.
The right sidebar has a widget with the plugins shortcode in it.

The following is the source code showing the DIV “wpcr_respond_1” being called twice.
The source code shows that the first instance of the DIV is in the main page text because you can see the closing DIVs for other DIVs – such as the “entry-content”, “content-area”, “article” etc.

<p>This paragraph is the last of the text on the about-us page</p>
<div id="wpcr_respond_1"></div>
</div><!-- .entry-content -->
</article><!-- #post-859 -->
</div><!-- #content .site-content -->
</div><!-- #primary .content-area -->

<div id="secondary" class="widget-area" role="complementary">
<aside id="text-2" class="widget widget_text"><h1 class="widget-title">Customer Reviews</h1>
<div class="textwidget">
<div id="wpcr_respond_1">

Again, as the shortcode is not in the page text, and the plugin is called in the theme’s sidebar widget, I do not see what else this could be other than a perhaps function or something else within your theme that is calling the DIV in the page before the sidebar.
I have not changed your theme files.

It could be something in the plugin, but again, the plugin has no control over the page text, only when it’s called in the sidebar widget.

Thanks again!

[Author]

Posts