Viewing 14 posts - 1 through 14 (of 14 total)
  • Author
    Posts
  • #5339

    If you have sub-pages, the responsive menu is broken.  When you scale the browser down so that the small responsive menu appears, the selected item is always the last item in the menu list, no matter what page you are actually on.  You can actually see this but on most of the Catch Theme preview pages.  I happen to be using the Catch Everest theme, but the bug seems to be fundamental to all of the Catch themes.

    Just scale down the size of the window on any of these demo pages and you will see that the current page is always set to the last item in the menu drop down (rather than the actual current page).

    http://catchthemes.com/preview/?theme=Catch+Box

    http://catchthemes.com/preview/?theme=Catch-Mustang

    http://catchthemes.com/preview/?theme=Catch+Responsive

    Note that the Catch Everest sample page doesn’t have this bug, but note that the sample (unlike all of the other samples) doesn’t have a sub-page.  If the site doesn’t have any sub pages, the responsive tiny menu appears to work correctly.  In my personal catch everest themed site (which does have sub-pages), the bug appears.

    http://catchthemes.com/preview/?theme=catch-Everest

     

    Is there a way to fix the tiny menu so that it works correctly?

     

    #5341

    I found the bug.  In catcheverest-menu.js, the call to tinyNav (on line 90) has the wrong class name specified.  Instead of ‘current-menu-item’, it should use ‘current-page-item’.  If you make that change, the menu works correctly.

    I also changed the default in the tinyNav function (line 17) to be ‘current-page-item’ as well, just for good measure, although it isn’t really necessary.

    My guess is the same bug is in all of your themes.

    #5342

    Sorry, the correct selected class is current_page_item, not current-page-item.

    #5344
    Robertf
    Participant

    I had the same problem but followed Sakin’s instructions to use a Custom Menu. Now works fine for me 😉

    #5356
    Sakin
    Keymaster

    @pitaandfreddy: the menu defined in the theme is perfectly fine. As we focus on Custom Menu feature of WordPress. Not the page menu. Custom Menu adds in current-menu-item for the current item.

    If you see at the demo of Catch Everest. http://catchthemes.com/demo/catch-everest/ Where is the bug. It is selecting the proper menu.

    No problem in demo of Catch Box http://catchthemes.com/demo/catchbox/
    No problem in demo of Catch Box Pro http://catchthemes.com/demo/catchbox-pro/

    No problem in demo of Catch Mustang http://catchthemes.com/demo/catch-mustang/

    No problem in demo of Catch Responsive http://catchthemes.com/demo/catchresponsive/

    No problem in Simple Catch Pro http://catchthemes.com/demo/simplecatch-pro/

    Please post the support query if you have problem. I will personally help you. But please don’t post false judgement.

    #5405
    Sakin
    Keymaster

    @pitaandfreddy: Please use Custom Menu instead of Page Menu. See this http://en.support.wordpress.com/menus/

    #5414

    Thanks for the info that the themes don’t support page menu and only support custom menus for adaptive rendering.  That doesn’t work for my needs, but perhaps this will help someone else that notices this issue.

    BTW, the contention above that the Catch Mustang and Catch Responsive demo sites work correctly is wrong.  You should probably update your demo sites so that they use Custom Menus.  Here are the steps to reproduce the error on your demo sites:

    Navigate to http://catchthemes.com/demo/catch-mustang/
    Make sure browser is full width and notice that “Home” is selected in the menu.
    Shrink the width of the browser so that the adaptive rendering takes hold and the tiny menu is displayed.
    Note that “Services”, not “Home”, is incorrectly selected in the menu.
    Select “About” from the menu.
    Note that while you are taken to the “About” page, note that the tiny menu still has “Services” selected.
    Expand the width of the browser so that the standard menu is displayed and note that “About” is correctly selected.

    On the catch responsive theme (http://catchthemes.com/demo/catchresponsive/) demo, the same issue applies.  When the width of the browser is reduced, “A Category” is always selected no matter what page you are on.

    I don’t know if the other sites have been fixed since (it looks like some of them have been), but I know that every one that I listed as having an issue had the bug at the time I made the post.  Note that I explicitly said in my original post that the Catch Everest theme demo did not demonstrate the issue, but only because (I suspected) it didn’t have any sub-pages (unlike all the rest of your demos).

    Regardless, you probably want to double check all of your demos (something I haven’t and won’t bother to do) and tweak them to address this as some of the demos (as documented above) still display the issue.

    Oh, and finally, @Sakin, I didn’t post false judgment.  I pointed out a real and reproducible (even on your demo sites) issue.  I was trying to help you, the developers of a generally nice set of themes, by pointing out an issue that could affect any users of your theme (including you — as referenced by the fact that the issue is still found on your demo sites as I type this).  I don’t appreciate the tone of your initial response or your implications, especially given that I went so far as to dig through the code and even posted what I thought was a solution to help try to make the product better.  But whatever.  A good developer will accept criticism and bug reports without attacking the reporter of the issue and looks to use them to make their products better.  Attacking customers because of the limitations of your products is neither professional nor a good business model.

    I haven’t seen anything in the documentation or the settings saying that the themes don’t work correctly with standard page menus if you have sub pages.  Given that your own demos are afflicted by this issue, you might want to consider making that limitation more prominent in either the documentation or admin pages (or both).  If this is, in fact, working as intended (and I would challenge that it is correct, frankly, as I would think you could pretty easily tweak the code to support both page and custom menus by just parameterizing the selected menu class), then at the very least this is a documentation issue.

    Thanks for your time anyway.

    #5415
    Sakin
    Keymaster

    @pitaandfreddy: That is really strange that the demo for Catch Responsive and Catch Mustang both are working fine on my site and they both uses Custom Menu not page menu. Can you refresh and check it.

    Sorry I though you were judging the theme as you didn’t explain for ask for support and then you directly write “responsive menu bug (exists on most if not all Catch themes)”. If you have asked for me then I would have given you the support to fix it.

    Ok I have taken this into consideration for the menu to support both page and custom menu soon.

    Thanks for your feedback.

    #14140
    tjrenk
    Member

    Hi Sakin,

    I’ve used catch-box theme on my sites. I’ve 2 separate custom menu for my site, one is in Indonesian (primary language) and English.

    I also have problem when it comes to mobile device. The last menu item is always displayed on the menu where ever I switch to any pages on my site (in my english version), while on my main language menu are fine except the last menu item is missing from the menu.

    here is my site address, http://www.ipeka.org

    any clue would be a lot help to me.

    Thanks Sakin

    Thomas

    #14146
    Sakin
    Keymaster

    @tjrenk: Looks like you have customize the site that is why it is giving issue. You can add the following CSS in “Appearance => Theme Options => Custom CSS”

    .tinynav option:last-child {
        display: block;
    }
    #14160
    tjrenk
    Member

    @sakin: Wow, that solved the problem on my main language (indonesian) but still nothing change on the english translation.

    Thanks Sakin

    #14161
    Sakin
    Keymaster

    @tjrenk: You can add the same thing in the english website as well. What the website url of english site.

    #14165
    tjrenk
    Member

    @sakin: Actually, my website is built using qtranslate for multilanguage feature.
    the link to my english site is http://www.ipeka.org/en/

    Thanks Sakin

    #14176
    Sakin
    Keymaster

    @tjrenk: For me it is showing for English version as well. Also there will be fixed for this issue in next update version 2.7.1

Viewing 14 posts - 1 through 14 (of 14 total)
  • The topic ‘responsive menu bug (exists on most if not all Catch themes)’ is closed to new replies.