[pitaandfreddy]

Thanks for the info that the themes don’t support page menu and only support custom menus for adaptive rendering.  That doesn’t work for my needs, but perhaps this will help someone else that notices this issue.

BTW, the contention above that the Catch Mustang and Catch Responsive demo sites work correctly is wrong.  You should probably update your demo sites so that they use Custom Menus.  Here are the steps to reproduce the error on your demo sites:

Navigate to http://catchthemes.com/demo/catch-mustang/
Make sure browser is full width and notice that “Home” is selected in the menu.
Shrink the width of the browser so that the adaptive rendering takes hold and the tiny menu is displayed.
Note that “Services”, not “Home”, is incorrectly selected in the menu.
Select “About” from the menu.
Note that while you are taken to the “About” page, note that the tiny menu still has “Services” selected.
Expand the width of the browser so that the standard menu is displayed and note that “About” is correctly selected.

On the catch responsive theme (http://catchthemes.com/demo/catchresponsive/) demo, the same issue applies.  When the width of the browser is reduced, “A Category” is always selected no matter what page you are on.

I don’t know if the other sites have been fixed since (it looks like some of them have been), but I know that every one that I listed as having an issue had the bug at the time I made the post.  Note that I explicitly said in my original post that the Catch Everest theme demo did not demonstrate the issue, but only because (I suspected) it didn’t have any sub-pages (unlike all the rest of your demos).

Regardless, you probably want to double check all of your demos (something I haven’t and won’t bother to do) and tweak them to address this as some of the demos (as documented above) still display the issue.

Oh, and finally, @Sakin, I didn’t post false judgment.  I pointed out a real and reproducible (even on your demo sites) issue.  I was trying to help you, the developers of a generally nice set of themes, by pointing out an issue that could affect any users of your theme (including you — as referenced by the fact that the issue is still found on your demo sites as I type this).  I don’t appreciate the tone of your initial response or your implications, especially given that I went so far as to dig through the code and even posted what I thought was a solution to help try to make the product better.  But whatever.  A good developer will accept criticism and bug reports without attacking the reporter of the issue and looks to use them to make their products better.  Attacking customers because of the limitations of your products is neither professional nor a good business model.

I haven’t seen anything in the documentation or the settings saying that the themes don’t work correctly with standard page menus if you have sub pages.  Given that your own demos are afflicted by this issue, you might want to consider making that limitation more prominent in either the documentation or admin pages (or both).  If this is, in fact, working as intended (and I would challenge that it is correct, frankly, as I would think you could pretty easily tweak the code to support both page and custom menus by just parameterizing the selected menu class), then at the very least this is a documentation issue.

Thanks for your time anyway.

[pitaandfreddy]

Sorry, the correct selected class is current_page_item, not current-page-item.

[pitaandfreddy]

I found the bug.  In catcheverest-menu.js, the call to tinyNav (on line 90) has the wrong class name specified.  Instead of ‘current-menu-item’, it should use ‘current-page-item’.  If you make that change, the menu works correctly.

I also changed the default in the tinyNav function (line 17) to be ‘current-page-item’ as well, just for good measure, although it isn’t really necessary.

My guess is the same bug is in all of your themes.

[Author]

Posts