[Haydie]

Hello!
Did you get any feedback on this one from WPML?

They’re pretty silent when I ask if they have a solution.

This really needs to be fixed. Or else you should consider removing the “WPML ready” info from the theme info page.

The theme is only WPML compatible if you have english as default language! Not for the rest of us…

best regards Johan

[Haydie]

Hello!
I have posted a support request at the wpml.org forums.

https://wpml.org/forums/topic/wpml-compatibility-with-adventurous-pro-theme-default-language-swedish/

A guy named Abdallah from their support staff has logged in to my site and verified the bug.

The issue is escalated to their compatibility team.

best regards Johan

[Haydie]

Hi!
I have filed a support issue at WPML as well.

They will look into it (I have provided them with login information).

Thanks for your patience!

best regards Johan

[Haydie]

Hi again!

I’m sorry if I’m not giving up on this one…

According to the WPML String translation documentation all strings should be entered in English even if default language is not English (and even if English is not used at all on the site).

See String translation doc/ Chapter “Original language of strings”.

If I enter Swedish in Theme options, these are shown as if they were English strings in WPML String translation and are expected to be translated to Swedish which makes no sense.

Anyway…

If it’s a WMPL issue then the error would appear with the built in Text widget as well. But it doesn’t.

Try it yourself
– Swedish as default language
– Built in text widget
– Title and text in english
– Translate with WPML str.tr.
– Site shows correct texts in both languages
– Widget admin area still shows title and text in english
– Widget admin area does NOT flip title and text to Swedish as in Adventurous / Theme options!

I really hope you can sort this out together with WPML. The promo headline and featured content features can’t be used if default language is other than English. Sorry!

best regards Johan

[Haydie]

Hello again!
I’ve done some more testing!

The bug occurs when sites default language is a language other than English. Did you try that?

theme-testing.wpml.org/adventurous/ has English as default language.

See the bug by doing this:

– Set WPML default language to Swedish
– Set the promotion headline to some value in English (according to WPML docs it should be in English)
– Translate it to Swedish using WPML String translation
– Verify Swedish start page http://the.site/ (has correct Swedish value)
– Verify English start page http://the.site/en (has correct English value)
And to see the bug:
– Go back to Theme options / Promotion headline
– The value has changed to the Swedish translation
– The English value should be there!

Theme picks up strings correctly in two places (start page in eng & swe), incorrectly in another place (theme options)!

It just has to be a theme issue!

best regards Johan

[Haydie]

You need to look into this! The error occurs in the theme admin pages!

The Theme options / promotion headline form incorrectly picks up the Swedish strings after the original English strings have been translated! Same thing with featured content.

My guess. Site admin language other than English is the problem here. Have you tested that?

I doubt it’s a wpml plugin error. If it is then the string translation form should mix up the different language versions of the strings. But it doesn’t.

I can try to switch site admin language to English just to see if the error remains. (Though English for admins is not an option for production).

And sure I can post a support request to wpml.

Best regards Johan

[Haydie]

It’s added in the child theme CSS at lines 41-45 or so.

http://fjallbua.se.preview.binero.se/wp-content/themes/adventurous-fjallbua/style.css

Don’t look at the menu while scrolling. Look at the content. At the exact moment when the menu becomes fixed the content jumps up some 90 pixels!

Check in on http://catchthemes.com/demo/adventurous/
Second tiger, mouse pointer in tigers eye, scroll down.
When pointer reaches tigers first whisker menu pops over to fixed and tigers whiskers jump up quite a bit!

best regards Johan

[Haydie]

The fixed menu effect is great!

But I don’t think your intention was to make content suddenly jump nearly a 100 pixels!

You can test my fix here: http://fjallbua.se.preview.binero.se/

Note: site is under development!!

And a (corrected) fix could be:

.fixed-header + #main-wrapper, 
.fixed-header + #main-wrapper + #colophon {
    position: relative;
    top: 91px;
}

🙂

best regards Johan

[Haydie]

Hello!
I have it in style.css in my child theme.

Though I’m pretty sure you can paste it in
wp-admin / Left menu / Appearance / Theme options / Custom CSS

You can leave the width: 100% out

@media screen and (max-width: 480px) {
    #footer-sidebar #supplementary .widget-area {
        margin-left: 0;
    }
}

Good luck!

best regards Johan (hmmm not Haydie, she’s the license owner, I’m the developer 🙂

[Author]

Posts